From 33069a070da5cc1d238c293129a5d853c281e886 Mon Sep 17 00:00:00 2001
From: serversdown <brian@serversdown.net>
Date: Mon, 15 Jun 2026 23:28:16 +0000
Subject: [PATCH] test: tidy conftest fixtures per review (drop dead
 try/finally, scope override cleanup, rm unused import)

---
 tests/conftest.py | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/tests/conftest.py b/tests/conftest.py
index 3e66e1f..aa44991 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -1,6 +1,5 @@
 """Test harness: a throwaway SQLite DB per test, get_db overridden, a TestClient
 that does NOT run lifespan startup (so schedulers/SLMM polling stay off)."""
-import os
 import uuid
 import pytest
 from datetime import datetime
@@ -30,15 +29,12 @@ def db_session(tmp_path):
 def client(db_session):
     from backend.main import app  # imported lazily so module side effects are contained
     def _override():
-        try:
-            yield db_session
-        finally:
-            pass
+        yield db_session
     app.dependency_overrides[get_db] = _override
     # No `with` → lifespan/startup events do not run (no scheduler/SLMM threads).
     c = TestClient(app)
     yield c
-    app.dependency_overrides.clear()
+    app.dependency_overrides.pop(get_db, None)
 
 
 @pytest.fixture(autouse=True)