seismo-lab2 #7

2026-04-26T16:49:16-04:00

serversdown commented

2026-04-26 16:49:16 -04:00

merges commits made by claude code pushed to github remote.

serversdown added 2 commits 2026-04-26 16:49:16 -04:00

fix(parser): correct S3 frame terminator — bare ETX, not DLE+ETX 9bbecea70f

parse_s3 had the S3 terminator logic inverted vs the real S3FrameParser
in framing.py. It was terminating on DLE+ETX and treating bare ETX as
payload, which caused every bare 0x03 to be swallowed — bundling multiple
real S3 frames into one giant body until a DLE+ETX sequence happened to
appear. Result: 583-byte POLL_RESPONSE 'frames' containing many real
frames concatenated, all showing BAD CHK.

Fix: mirror S3FrameParser exactly —
  - Bare ETX (0x03) = real frame terminator
  - DLE+ETX (0x10 0x03) = inner-frame literal data (A4/E5 sub-frames),
    appended to body and parsing continues

https://claude.ai/code/session_014NczSHUz9uTzCAf4cVASTJ

fix(analyzer): name A5/5A frames; revert S3 checksum validation e1150b30aa

Add 0x5A (BULK_WAVEFORM_STREAM) and 0xA5 (BULK_WAVEFORM_RESPONSE) to
SUB_TABLE so they display with real names instead of UNKNOWN_5A/A5.

Revert S3 checksum validation to checksum_valid=None (the original
intentional behavior). Large S3 frames (A5 bulk waveform, E5 compliance
config) embed inner DLE+ETX sub-frame delimiters; the trailing 0x03 of
the last inner delimiter can land where the parser expects the SUM8
checksum byte, causing false BAD CHK on every valid A5 frame.
protocol.py _validate_frame documents and ignores exactly this issue.

https://claude.ai/code/session_014NczSHUz9uTzCAf4cVASTJ

serversdown merged commit 310fc5986c into seismo-lab

2026-04-26 16:49:29 -04:00

serversdown referenced this issue from a commit

2026-04-26 16:49:32 -04:00

Merge pull request 'seismo-lab2' (#7) from seismo-lab2 into seismo-lab

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: serversdown/seismo-relay#7